cbcde34540
fix(errors1): Add a comment to make the purpose more clear ( #486 )
...
Signed-off-by: zydxhs <johnsmithcry@163.com>
2022-02-04 15:00:24 +01:00
1622e8c198
fix(quiz1): update to say quiz covers "If"
2021-12-29 14:55:37 +08:00
f2650de369
fix(clippy1): Updated code to test correctness clippy lint with approx_constant lint rule
...
closes #888
2021-12-15 11:46:27 -05:00
d1ee2daf14
fix(structs3.rs): assigned value to cents_per_gram in test
...
Intended to simplify the lesson by removing the need to figure out what the value is meant to be based on the tests.
Previous commits (9ca08b8f2b114b54cbdb (diff-ce1c232ff0ddaff909351bb84cb5bff423b5b9e04f21fd4db7ffe443e598e174)
2021-10-30 16:55:58 -06:00
1663a16ead
fix(traits1): rename test functions to snake case ( #854 )
...
Co-authored-by: zhangshaozhi <zhangshaozhi@ZhangshaozhideMacBook-Pro.local>
2021-10-18 13:57:12 +02:00
46c28d5cef
fix(move_semantics5): correct typo ( #857 )
2021-09-30 10:18:36 +02:00
bf33829da2
fix(structs3): remove redundant 'return' ( #852 )
2021-09-27 10:03:28 +02:00
c2ed98deb3
Merge pull request #781 from tlyu/advanced-errs
...
feature: advanced errors
2021-09-25 11:18:55 +02:00
abd6b70c72
feat: add advanced_errs2
...
New exercise to demonstrate traits that make it easier for other code
to consume our custom error types.
2021-09-25 11:18:23 +02:00
882d535ba8
feat: add advanced_errs1
...
New section and exercise to demonstrate the `From` trait for errors
and its usefulness with the `?` operator.
2021-09-25 11:18:21 +02:00
d75759e829
fix(move_semantics5): change &mut *y to &mut x ( #814 )
...
Instead of having to explain why
```rs
let mut x = 100;
let y = &mut x;
let mut z_owned = *y;
let z = &mut z_owned;
*y += 100;
*z += 1000;
```
and
```rs
let mut x = 100;
let y = &mut x;
let z = &mut *y;
*y += 100;
*z += 1000;
```
are different, you still get the point across about having only one mutable reference.
As it stands, this exercise does too much (dereferencing and having only one mutable reference), and by doing so confuses people.
Example of someone being confused by this:
<https://discord.com/channels/273534239310479360/273541522815713281/872689531428692040 >
2021-09-25 10:52:18 +02:00
0a11bad714
feat(quiz1): add default function name in comment ( #838 )
2021-09-21 10:43:44 +02:00
1c3beb0a59
fix(modules2): fix typo ( #835 )
2021-09-06 16:32:39 +02:00
dfd2fab4f3
feat(modules): update exercises, add modules3 ( #822 )
...
Co-authored-by: diannasoriel <mokou@fastmail.com>
2021-09-03 10:41:12 +02:00
96fc301764
chore(quiz1): revert wording
2021-08-26 10:30:18 +02:00
03131a3d35
fix(quiz1): Fix inconsistent wording ( #826 )
...
The second test expects the function to return 80 when there is an order of 40 apples, but the current wording implies returning 40 will pass as well
2021-08-24 10:48:51 +02:00
df25684cb7
fix(move_semantics5): Clarify instructions
2021-07-29 12:37:15 +02:00
8e313cffaa
Merge pull request #732 from apogeeoak/iterators5
...
chore(iterators5): Minor formatting improvements.
2021-07-09 12:24:42 +02:00
6948905716
Merge pull request #737 from ghost/correct-small-typo
...
Correct small typo in exercises/conversions/from_str.rs
2021-07-08 11:07:21 +02:00
d876649616
fix(quiz1): Updated question description ( #794 )
...
Co-authored-by: Rakshit Sinha <rakshit.sinha@oracle.com>
2021-07-07 22:18:33 +02:00
8774e47dc3
docs: Update collections README with HashMap link
2021-07-06 01:31:27 -07:00
e422ab1507
docs: Update exercise to chapter mapping for HashMap
2021-07-05 23:07:34 -07:00
2dc93cadda
fix(from_str, try_from_into): custom error types
...
Remove the use of trait objects as errors from `from_str` and
`try_from_into`; they seem to have caused a lot of confusion in
practice. (Also, it's considered best practice to use custom error
types instead of boxed errors in library code.) Instead, use custom
error enums, and update hints accordingly. Hints also provide
some guidance about converting errors, which could be covered
more completely in a future advanced errors section.
Also move from_str to directly after the similar exercise `from_into`,
for the sake of familiarity when solving.
2021-06-24 21:33:41 -05:00
a3ea37b76e
Merge pull request #771 from tlyu/iterators5-trait-tweak
...
fix(iterators5): derive Clone, Copy
2021-06-24 14:17:05 +02:00
ec63cadadb
Merge pull request #772 from tlyu/errors-rework
...
feature: improve error_handling exercises
2021-06-24 14:12:34 +02:00
b7ddd09fab
address review feedback
...
Adjust error text and naming to conform with best practices.
Use `map_err()` instead of `or()`. Wrap lower-level errors instead of
ignoring their details.
Also, don't "cheat" by bypassing the `new()` function in tests.
Fix a dangling reference in the try_from_into hints.
2021-06-09 23:27:53 -05:00
48ffcbd2c4
fix(variables5): confine the answer further
...
let mut number = 3; can lead to a correct answer, so the comment helps to direct the users to the intended answer.
2021-06-07 18:22:55 +08:00
68d3ac567c
feature: improve error_handling exercises
...
Add new exercises errors5 and errors6, to introduce boxed errors and
custom error enums more gently. Delete errorsn, because it tried to do
too much too soon.
2021-06-06 23:08:57 -05:00
50ab289da6
fix: rename result1 to errors4
...
Also put it in the ERROR HANDLING section where it probably belongs.
2021-06-06 23:08:54 -05:00
91fc9e3118
fix(iterators5): derive Clone, Copy
...
To allow more flexibility in solutions, derive `Clone` and `Copy`
for `Progress`.
2021-06-06 17:38:02 -05:00
1b85828548
fix: move_semantics5 hints
...
Improve the hints for move_semantics5, as well as the explanatory
comments in the code.
Previously, it was not clear what possible changes were allowed.
It seems that reordering the statements might be the intended solution.
The previous comment about not "adding newlines" doesn't make sense,
so treating it as "adding new lines" makes it more clear.
2021-05-22 22:09:58 -05:00
399ab328d8
feat: Add move_semantics5 exercise. ( #746 )
...
* feat: Add move_semantics5 exercise.
* feat: Add option3 exercise
* Address review comments. Fix typos, sentence formatting.
* Remove unwanted newline.
* Address review comments: make comment inline, fix format in print.
2021-05-17 14:10:40 +02:00
4d4fa77459
fix: remove trailing whitespaces from iterators1
2021-05-12 10:20:07 -05:00
3145794084
fix: add hints to generics1 and generics2 exercises
2021-05-11 14:50:05 -05:00
d9b69bd1a0
fix: remove trailing whitespace
2021-05-09 17:58:54 -05:00
9569c9a9e7
style(standard_library_types): stray line break
2021-04-29 23:31:26 +02:00
86cc85295a
fix: Correct small typo in exercises/conversions/from_str.rs
2021-04-27 21:11:40 +02:00
9b8de65525
fix(intro1): Add compiler error explanation.
2021-04-26 20:28:17 -04:00
650b1dee54
chore: Update quiz1.rs add explicit test for 40
2021-04-25 19:02:50 +02:00
21c9f44168
feat(intro): Add intro section.
2021-04-24 13:15:34 -04:00
7f0d2c2bf0
chore(iterators5): Minor formatting improvements.
2021-04-24 12:42:06 -04:00
4a384cae4a
docs(option): improve further information
2021-04-24 12:12:49 +02:00
249ad44cc0
docs(exercises): updated all exercises readme files
...
all exercises readme files now have a unified structure and a description
2021-04-23 19:54:31 +02:00
54804e344d
Merge pull request #721 from Zerotask/add-further-help-for-generics3
...
docs(generics): add bounds help
2021-04-23 15:05:00 +02:00
f253103a31
docs(generics): add bounds help
...
add help for bounds provided by the rust by example book
2021-04-22 22:11:04 +02:00
1120db57a6
docs(errors): add additional help for Result/Boxing
...
add additional help information provided by the rust by example book
2021-04-22 21:32:29 +02:00
81be404487
feat(arc1): Add more details to description and hint ( #710 )
...
Co-authored-by: bmacer <bmacer@cisco.com>
Co-authored-by: marisa <mokou@fastmail.com>
Co-authored-by: Roberto Vidal <vidal.roberto.j@gmail.com>
2021-04-21 14:50:03 +02:00
79cc657917
Merge pull request #646 from apogeeoak/iterator
...
Added iterators5.rs exercise.
2021-04-21 10:10:50 +02:00
9c88ea9126
Improved iterators5.rs explanation.
2021-04-20 18:55:04 -04:00
2b766ef9f9
Merge pull request #648 from apogeeoak/iterator2
...
Moved iterators2.rs errors out of tests.
2021-04-20 11:24:10 +02:00
bd3d9ac9d5
Merge pull request #649 from apogeeoak/iterator3
...
Enabled iterators3.rs to run without commented out tests.
2021-04-20 11:22:39 +02:00
6bd791f2f4
fix(structs): Add 5.3 to structs/README ( #652 )
...
Co-authored-by: Shao Yang Hong <shaoyang.hong@ninjavan.co>
2021-04-20 11:19:24 +02:00
b4de659438
fix(option2): Rename uninformative variables ( #675 )
...
Renaming uninformative names like `optional_value`, `value`, `optional_values_vec` and `value` helps users distinguish between the two parts of the task.
2021-04-20 11:18:05 +02:00
72aaa15e6a
fix(hashmap2): Update incorrect assertion ( #660 )
...
The test description says "at least five types of fruit", but the test itself is checking for exactly five types of fruit, which was a bit misleading for newcomers like me :)
A simple change from "==" to ">=" should do the trick and successfully check for the "at least" condition.
2021-04-20 11:15:49 +02:00
f2ad3a6a0b
Merge pull request #697 from WowSuchRicky/main
...
Rename 'Lichi' to 'Lychee' in the fruit example
2021-04-13 10:40:07 -04:00
caf921a01f
Merge pull request #674 from Morsicus/fix/collections-exercises-naming
...
Update collections exercises naming
2021-04-13 10:39:18 -04:00
b790bafc02
Rename lichi to lychee in the fruit example
2021-04-09 14:08:02 -07:00
c3e7b83178
fix: use trait objects for from_str
...
Use `Box<dyn error::Error>` to allow solutions to use `?` to propagate
errors.
2021-04-04 18:56:10 -05:00
2e93a588e0
fix: use trait objects for try_from_into
...
Use `Box<dyn error::Error>` to allow solutions to use `?` to propagate
errors. In the tests, explicitly check `is_ok()` instead of trying to
force the error type to `String` (or other `PartialEq` type) using
`assert_eq!()`.
2021-04-04 12:41:32 -05:00
a6509cc4d5
fix(functions3): improve function argument type ( #687 )
2021-04-04 09:43:25 +02:00
3df094713f
chore: capitalize `c` letter
...
By capitalizing the `c` letter it makes clear that we're talking about the C programming language.
2021-03-20 21:12:49 +01:00
ab9995e76e
doc: Update collections exercises instruction to match the standard naming
2021-03-18 19:11:15 +01:00
bef39b1259
fix(collections): Naming exercises for vectors and hashmap
2021-03-18 19:11:04 +01:00
0d894e6ff7
fix(quiz3): Force an answer to Q2 ( #672 )
...
Add also an example of unimplemented!() macro.
2021-03-16 10:14:25 +01:00
3bce2ef8d6
chore: clarify collections documentation
...
C++ `map` is more like BTreeMap.
`unordered_map` in C++(11) is the equivalent of `HashMap` in Rust.
(+ additional like for references).
2021-03-15 09:14:12 +01:00
9f3e8c2dde
fix(structs3): reword heading comment ( #664 )
2021-03-13 12:14:02 +01:00
05a753fe63
fix: add check to prevent naive implementation of is_international
...
* fix(structs3): Add check to prevent naive implementation
* chore(structs3): Add a missed newline after the test I added
2021-03-12 18:36:35 +01:00
5f7c89f85d
fix(from_str): Correct typos
...
typos in the comments
2021-02-21 21:50:17 +01:00
c6712dfccd
fix(iterators3): Enabled iterators3.rs to run without commented out tests.
2021-02-12 15:36:53 -05:00
baf4ba175b
fix(iterators2): Moved errors out of tests.
...
Closes #359
2021-02-11 21:24:32 -05:00
b29ea17ea9
feat: Added iterators5.rs exercise.
2021-02-10 18:03:29 -05:00
cc266d7d80
fix(move_semantics4): Remove redundant "instead" ( #640 )
2021-02-07 12:22:13 +01:00
15e71535f3
fix(from_str): test for error instead of unwrap/should_panic
2021-01-21 07:55:22 -05:00
4f1374a6e7
feat(from_into) : add test for checking unnecessary trailing value
2021-01-09 00:08:38 +09:00
5a0521e92c
feat(from_str) : add test for checking unnecessary trailing value
2021-01-09 00:07:13 +09:00
7857b0a689
fix(threads1): line number correction
2021-01-06 13:47:20 +01:00
10965920fb
fix(move_semantics4): Small readbility improvement ( #617 )
...
* Small readbility improvement move_semantics4 doc
* Remove `an` as it refers to the argument
2021-01-06 10:12:33 +01:00
0ef95947cc
fix(functions2): Change signature to trigger precise error message: ( #605 )
...
Now trigger this error:
```
error: expected type, found `)`
--> exercises/functions/functions2.rs:10:16
|
10 | fn call_me(num:) {
| ^ expected type
```
2020-12-27 12:36:38 +01:00
bcf14cf677
fix: update structs README
2020-12-15 08:32:46 +01:00
90cfb6ff28
fix: added missing exercises to info.toml
2020-12-12 10:34:59 -08:00
30644c9a06
fix: gives a bit more context to magic number
2020-12-08 10:08:25 +01:00
033bf1198f
feat: match exercise order to book chapters ( #541 )
...
Added exercise to book chapter mapping table to exercise README
2020-12-07 15:37:19 +01:00
cdc7d92e57
Merge pull request #592 from tinkhauser/vec1_bugfix
...
fix(vec1): Have test compare every element in a and v
2020-12-06 15:09:45 +01:00
04f1d079aa
feat(try_from_into): remove duplicate annotation
2020-12-03 17:51:30 +01:00
9b6c629397
fix(vec1): Have test compare every element in a and v
...
The previous test would stop comparing elements in array a and vec v upon reaching the last element of either. This resulted in the test passing even if v did not contain all the elements in a. This change to the test fixes that bug and should only pass if all the elements in a and v are present and equal.
2020-11-29 01:35:14 +00:00
4f4cfcf3c3
fix(try_from_into): type error
2020-11-11 21:02:00 -08:00
96347df9df
fix(try_from_into): Update description ( #584 )
...
Description update
2020-11-08 19:30:40 +01:00
95ccd92616
feat(try_from_into): Add tests ( #571 )
...
Co-authored-by: Volodymyr Patuta <6977238-fiplox@users.noreply.gitlab.com>
2020-11-07 14:01:39 +01:00
197d3a3d89
fix(iterators2): Update description ( #578 )
...
grammar fix in the description
2020-11-07 13:54:14 +01:00
633c00cf80
feat: Add HashMap exercises
2020-10-31 01:11:04 +06:00
0c12fa31c5
feat: Add Vec exercises
2020-10-31 01:10:49 +06:00
472d8592d6
fix(primitive_types6): remove 'unused doc comment' warning
2020-10-13 23:20:17 -07:00
4fb230daf1
fix(primitive_types6): missing comma in test
2020-10-13 23:18:41 -07:00
2b1fb2b739
feat(primitive_types6): Add a test ( #548 )
...
Co-authored-by: Annika <56906084+AnnikaCodes@users.noreply.github.com>
Co-authored-by: fmoko <mokou@posteo.de>
2020-10-10 16:04:19 +02:00
18e0bfef1d
fix(quiz3): Second test is for odd numbers, not even. ( #553 )
2020-10-10 13:11:57 +02:00
69fc9ce10e
Merge pull request #545 from YJDoc2/main
2020-10-01 12:17:05 +02:00
2ec0bdfd99
fix(variables5) : make shadowing more prominent
...
closes #375
2020-10-01 08:31:42 +05:30
2a682abeef
Merge pull request #522 from calvinbrown085/adding-test-for-false-case
2020-09-27 17:05:42 +02:00
2933f51949
chore: Change point to comma in from_into.rs
...
A typo in the fn test_bad_age() hint message had a point rather than comma
Prev:
// Test that "Mark.twenty"
Current:
// Test that "Mark,twenty"
2020-09-25 13:39:52 +02:00
bec97b6c76
Fixing test3 to have enough tests to make sure we test all cases
2020-09-21 15:23:19 -05:00
114b54cbdb
fix(structs3): Small adjustment of variable name
...
Co-authored-by: Jannek <squar@informatik.uni-hamburg.de>
2020-09-19 21:22:56 +02:00
0f16463794
Merge pull request #489 from mukundbhudia/iterators1
2020-09-18 15:23:28 +02:00
3286c5ec19
fix(using_as): Add test so that proper type is returned. ( #512 )
2020-09-07 19:09:27 +02:00
ee7cdc66b3
chore: Removed extra whitespaces
...
Co-authored-by: Corentin ARNOULD <corentin.arn@gmail.com>
2020-08-27 19:51:19 +02:00
6bb0b48b10
Make macros4 not compile by default
...
Did you mean this? I'm new to rust and this test passed right away, so unsure what the intention was.
2020-08-26 22:17:03 -04:00
101072ab9f
fix(exercises): adding question mark to quiz2
...
Question marks added for consistency.
closes #496
2020-08-25 16:38:41 +02:00
dd54ccf677
Make comments on example clearer
...
I actually struggled because I overlooked the fact that I needed to change the 2.1 to "A+".
So I wanted to make things clearer for future rustlings.
2020-08-24 22:37:31 +01:00
b4062ef699
fix(arc1): index mod should equal thread count
2020-08-16 20:55:50 -04:00
3144d3ae63
chore: Run rustfmt on exercises
2020-08-10 10:24:21 -04:00
9642f5a3f6
feat: Added iterators1.rs exercise
2020-08-04 12:57:01 +01:00
523d18b873
feat(try_from_into): Add insufficient length test ( #469 )
2020-07-13 11:39:05 +02:00
bb5f404e35
chore: Alter whitespace for consistency
...
* Add newline after "I AM DONE" in exercises for consistency
* Remove trailing whitespace from exercises
2020-07-11 11:50:54 -07:00
4b6540c71a
fix(enums3): Update Message::ChangeColor to take a tuple. ( #457 )
2020-07-08 11:56:43 +02:00
75c0053bb1
Merge pull request #433 from SebastienCaunes/fix#432
...
fix : Use of integer for prices, therefore also for weight
2020-06-22 00:09:09 +02:00
113cdae2d4
fix(arc1): Passively introduce attributes ( #429 )
...
Ensure that std::sync::Arc is actually used, as this exercise can be compiled using things already learnt in previous exercises.
2020-06-14 12:15:35 +02:00
9ca08b8f2b
fix : Use of integer for prices, therefore also for weight
...
rename confusing "from" and "to" to sender_country and recipient_country as suggested
2020-06-11 11:44:47 -05:00
307252e9ae
Added example to show the AsRef working
2020-06-08 07:51:34 -04:00
bb2ca25110
fix(box1): fix comment typo ( #426 )
...
Doesn't effect the code.
2020-06-06 12:07:39 +02:00
5563adbb89
fix: fix quiz naming inconsistency ( #421 )
...
Inconsistent naming when compared with the other quiz files.
2020-06-03 20:06:35 +02:00
524e17df10
fix(variables6): minor typo ( #419 )
...
Looks like this was cloned from variables5.rs
2020-06-03 13:34:43 +02:00
73e848e96f
Merge pull request #416 from danwilhelm/traits-readme
...
feat: Add traits README
2020-05-30 17:58:31 +02:00
5f0806967c
Merge pull request #409 from AlexandruGG/feature/box-exercise
2020-05-30 17:58:16 +02:00
173bb14140
feat: Add traits README
2020-05-28 20:21:33 -07:00
918f310674
Merge pull request #410 from tsauvajon/fix-option1
...
fix(option1): Don't add only zeros to the numbers array
2020-05-29 00:33:00 +02:00
0311c03735
chore: Limit generics3 lines to 90 chars
2020-05-27 23:39:11 -07:00
df81141d6f
Address PR feedback: add tests
2020-05-27 10:03:59 +01:00
cce6a44277
fix(option1): Don't add only zeros to the numbers array
2020-05-27 18:55:12 +10:00
7479a4737b
feat: Add box1.rs exercise
2020-05-26 21:46:24 +01:00
06ef4cc654
fix: confine the user further in variable exercises
...
We want to teach a specific lesson. To ensure that we do, let's try to
provide more clarity on what the user should not do.
2020-05-25 10:09:11 +02:00
c7c3130507
chore: remove struct2 hint comment
2020-05-20 08:31:28 +02:00
010a045692
feat: renames test to quiz, fixes #244
...
BREAKING CHANGE
* changed test to quiz: fixes issues in #244
* fixed info.toml: #244
* fixed naming related issues
2020-05-19 18:47:44 +02:00
51666609f1
Merge pull request #365 from sjmann/generics-2-fix
2020-05-19 17:49:55 +02:00
10967bce57
fix(option2): Add TODO to comments ( #400 )
2020-05-16 22:48:18 +02:00
763aa6e378
feat: Rewrite try_from_into ( #393 )
2020-05-15 23:02:57 +02:00
d6c0a688e6
fix(test2): name of type String and &str ( #394 )
2020-05-13 12:38:14 +02:00
2b20c8a0f5
fix(errorsn): Try harder to confine the user. ( #388 )
2020-05-06 21:12:15 +02:00
09e89bbcd3
Update Message::Move in the enums3 test to take a Point.
2020-05-04 18:59:23 -04:00
7c4b1f910c
Merge pull request #372 from DiD92/exercise_structs3
2020-05-03 19:44:26 +02:00
3ceabe91f8
Merge pull request #383 from wrobstory/wrobstory-exercises
2020-05-03 19:44:08 +02:00
a39ffb2fb8
Merge pull request #368 from apatniv/update_test_case
2020-05-03 13:31:46 +02:00
41f989135d
Review Comments: Add other test cases
2020-05-02 20:41:11 -04:00
f6cffc7e48
fix(option1): Add cast to usize, as it is confusing in the context of an exercise about Option
2020-05-02 16:39:37 -07:00
1da84b5f7c
feat: Add if2 exercise
2020-05-02 13:02:16 -07:00
c301814d68
chore: Remove deprecated description from error_handling/errorsn.rs
2020-05-02 18:30:11 +02:00
a901499ede
fix(from_into.rs): typo
2020-04-30 15:53:50 +02:00
9590082848
fix: update iterator and macro text for typos and clarity
...
- /macros/README.md: Typo "modules" => "macros"
- iterators2.py: Reduce line length to <90-char width.
- iterators4.py: Update 'fun' => 'challenge' as per PR#177
- rustlings hint iterators4: improve clarity
2020-04-29 19:11:54 -07:00
b66e2e0962
feat: Added exercise structs3.rs
2020-04-27 20:26:34 +02:00
19fb1c240c
test: Add missing test case for from_str exercise
2020-04-21 22:51:56 -04:00
630ff0e00b
chore: add explanatory comment to clippy1
2020-04-21 18:50:00 +02:00
964c974a02
fix: update generics2 closes #362
2020-04-21 13:34:25 +01:00
c9e4f2cfb4
fix: confusing comment in conversions/try_from_into.rs
...
Co-authored-by: Lebedev <sergey.lebedev@corp.mail.ru>
2020-04-17 15:43:01 +02:00
6c3cc2caf5
chore: delete orphaned `error_handling/option1.rs`
...
`error_handling/option1.rs` has been replaced by `option/option1.rs` and
is not referenced in `info.toml` any more.
2020-04-15 23:52:31 +02:00
5999acd24a
feat: Add exercise variables6 covering const ( #352 )
2020-04-14 10:13:20 +02:00
052f0aa7d4
Merge pull request #292 from Tuxified/patch-1
...
Remove duplicate not done comment
2020-04-08 11:23:49 +02:00
60393999b8
remove bottom comment instead of top
2020-04-08 11:00:11 +02:00
b3a3351e8e
fix: revert primitive_types4 ( #296 )
2020-04-08 10:42:35 +02:00
86b5c08b9b
feat: Add Option2 exercise ( #290 )
...
* added option2
* changed up the exercise, modified the help section
* Update exercises/option/option2.rs
Co-Authored-By: fmoko <mokou@posteo.net>
* Update exercises/option/option2.rs
Co-Authored-By: fmoko <mokou@posteo.net>
* Update exercises/option/option2.rs
Co-Authored-By: fmoko <mokou@posteo.net>
Co-authored-by: fmoko <mokou@posteo.net>
2020-04-07 20:16:10 +02:00
dab90f7b91
Remove duplicate not done comment
...
As indicated in #259 , I found it confusing to have 2 comments as the code wouldn't compile unless I solved both issues (I used the script from #281 to remove a comment and use `:wn` to go to next exercise, hence this tripped me).
2020-04-07 17:00:45 +02:00
3b6d5c3aaa
feature: makes "compile" exercise print output, resolves #270
...
When running "compile"-mode exercises in interactive `verify` mode,
we print their output when we prompt the learner if they want to
continue. This improves the "experimentation" experience, since
trying different things does produce a visible change.
2020-04-06 16:17:14 +02:00
7ce42941ea
Merge pull request #282 from sanjaykdragon/master
...
feat: added option exercise
2020-04-05 15:58:09 +02:00
b135b589e0
Merge pull request #280 from sjmann/generics-exercises
...
feat: added generics exercises
2020-04-05 14:40:34 +02:00
05ca3d77f7
Merge branch 'master' of https://github.com/sanjaykdragon/rustlings
2020-04-02 08:41:14 -04:00
6deee7e3e9
fixed spacing
2020-04-02 08:40:59 -04:00
9788496a85
Update option1.rs
2020-03-11 13:44:41 -04:00
6d3a412d47
Update option1.rs
2020-03-11 13:44:10 -04:00
bc22ec382f
adds additional test to meet exercise rules
2020-03-11 07:58:04 -07:00
135e5d47a7
feat: added excercise for option
2020-03-05 15:52:54 -05:00
0f8001ea44
add I AM NOT DONE comments
2020-02-28 00:31:55 +00:00
29b30ec946
Merge branch 'master' of https://github.com/sjmann/rustlings into generics-exercises
2020-02-28 00:19:45 +00:00
76be5e4e99
feat: added new exercises for generics
2020-02-28 00:09:08 +00:00
1e2fd9c92f
feat: Add clippy lints
...
- adds a new 'clippy' category for exercises
- clippy exercises should throw no warnings
- install script now also installs clippy
is related to https://github.com/rust-lang/rust-clippy/issues/2604
2020-02-26 14:07:07 +01:00
78295ce92f
Auto merge of #274 - sjmann:master, r=fmoko
...
chore: fixed merge conflicts from traits exercises added by s-marios
I hope this doesn't step on any toes but I wanted to try the traits exercises from #216 so I updated them to match the new structure with hints included in info.toml
2020-02-25 21:27:39 +00:00
a45486f2d0
Add a second test case
2020-02-25 14:25:03 +01:00
8b971ffab6
Enable test for exercise test4
2020-02-25 14:13:10 +01:00
dc84aacc65
remove confusing comment wording
2020-02-25 11:00:09 +00:00
b559cdd73f
added traits exercises
2020-02-25 09:48:50 +00:00
a3f70124dc
fixed typo
2020-02-22 14:28:07 +00:00
bec8e3a644
reworded missing exercise explanation
2020-02-22 13:04:37 +00:00
39fa7ae8b7
chore: Correct test command in tests1.rs comment
2020-01-29 13:48:43 +08:00
ade52ffb73
Fixed mangled sentence from book; edited for clarity
2020-01-25 03:24:14 -05:00
0c73609e6f
feat: Add variables5.rs exercise
...
closes #260
2020-01-14 21:10:07 +01:00
fd57f8f2c1
Created consistent money unit
2019-12-29 19:15:32 -05:00
dfdf8093eb
Enable a test and improve per clippy's suggestion.
2019-12-23 21:37:09 -05:00
fc26b5e151
I AM NOT DONE comment in conversions exercise files
2019-12-16 11:33:00 -05:00
0c85dc1193
feat: Add type conversion and parsing exercises
2019-12-16 09:12:13 -05:00
fe10e06c37
fix(tests1): Change test command
...
Closes #243 .
2019-12-16 13:05:25 +01:00
54571a5fca
fix(iterators2): Remove reference to missing iterators2.rs
2019-12-07 23:25:13 -08:00
31c25ebb50
Add link to chapter on pattern syntax
...
After being stuck on exercise enums3.rs for about an hour or two, having read the entire chapter on enums 2-3 times, and still being unable to complete the exercise, i started broadening my reading. I finally found the answer in the rust docs via google.
2019-11-24 09:28:33 +01:00
b565c4d3e7
fix: line numbers in several exercises and hints
...
The introduction of `I AM NOT DONE` shifted the lines of all
exercises, which now need adjustment.
2019-11-14 08:21:56 +01:00
c42c3b2101
fix(arc1): Fix some words in the comment
2019-11-12 18:37:23 +01:00
fda5a47069
fix(variables1): Correct wrong word in comment
2019-11-12 17:33:25 +01:00
ded2c034ba
fix(primitive_types4): update outdated comment
2019-11-12 12:52:28 +01:00
1a7bb5a400
Address feedback
2019-11-11 17:47:45 +01:00
ec2d4bd3ee
Merge branch 'master' into refactor-hints
2019-11-11 17:21:06 +01:00
9bdb0a12e4
feat: Refactor hint system
...
Hints are now accessible using the CLI subcommand `rustlings hint
<exercise name`.
BREAKING CHANGE: This fundamentally changes the way people interact with exercises.
2019-11-11 16:51:38 +01:00
2cdd61294f
feat: improve `watch` execution mode
...
The `watch` command now requires user action to move to the next
exercise.
BREAKING CHANGE: this changes the behavior of `watch`.
2019-11-11 16:23:35 +01:00
f72e5a8f05
fix(structs1): Remove misleading comment
2019-11-11 13:57:59 +01:00
6dcecb38a4
fix(strings): Move Strings before Structs
...
Closes #204 .
2019-11-11 13:46:42 +01:00
dcfb427b09
fix(errors3): Update hint
...
Closes #185 .
2019-11-11 13:37:43 +01:00
ad03d180c9
fix(if1): Remove `return` reference
...
This closes #153 .
2019-11-11 13:34:21 +01:00
c6dad28ddc
Auto merge of #224 - nyxtom:feat-enums, r=fmoko
...
feat: Add enums exercises
Creates an exhaustive list of enum exercises. This goes through the basics of different ways to derive enums with mixed data type variants, as well as the use of the all important `match` operator.
2019-11-09 09:41:36 +00:00
79a569422c
fix: Rewrite test1 logic
2019-10-29 20:53:41 +01:00
dc15032112
feat: Add enums exercises
2019-10-28 22:49:49 -05:00
2821227acf
chore: Clarify comment in exercises/test1.rs
...
closes #194
The author of issue #194 suggests that the wording of the comment is at
least ambiguous about the desired results. I believe this change more
clearly describes the expectation of the exercise.
2019-10-28 23:08:46 -04:00
2191ef7eee
Auto merge of #219 - vyaslav:master, r=fmoko
...
Added exercise for struct update syntax
Added one exercise for struct update syntax `struct2.rs`
2019-10-28 22:56:54 +00:00
ead4f7af9e
fix(option1): Fix arguments passed to assert! macro
2019-10-25 14:27:24 -07:00
1c4c8764ed
feat: Added exercise for struct update syntax
2019-10-21 14:50:59 +02:00
8109cbad97
fix(errorsn.rs) Update the deprecated syntax by adding dyn to trait objectscloses #211
2019-08-21 11:44:42 +01:00
5b1e673cec
fix(primitive_types4): Fail on a slice covering the wrong area
...
This commit converts primitive_types4 to a test and asserts that the
slice given is equal to the expected slice.
The intent of the primitive_types4 exercise appears to be to ensure the
user understands inclusive and exclusive bounds as well as slice syntax.
`rustlings` commands using `compile` do not verify that a specific
println is reached and, in the case of `watch` and `verify` (but not
`run`), they do not output the `println`s at all.
This fix is semantically similar to #198 . It does not take a stance on
the correct way to handle this for all exercises; see #127 . There are
likely other exercises whose intent are masked by this issue.
2019-08-17 17:16:19 -07:00
76b4cb5c00
chore: Correct typo
2019-08-12 11:45:40 +02:00
e3931718fb
chore(iterators2): Add exercise instructions
2019-08-09 07:38:21 -07:00
4cde86643e
fix(iterators2): Remove syntax resulting in misleading error message
...
closes #199
2019-08-09 07:37:27 -07:00
e0db987441
docs: Fix wrong title
...
fix #200
2019-07-27 22:14:48 +07:00
a750e4a1a3
fix(option1): Add test for prematurely passing exercise
...
Fixes the bug referenced in #160 , but does not address the larger feature work referenced by the issue.
2019-07-26 16:58:12 -07:00
4086d463a9
fix(test1): Swap assertion parameter order
...
`Expected` should come before `actual`, other wise it leads to confusing compiler messages, e.g.
```
note: expected type `()`
found type `{integer}`
```
2019-07-13 13:31:57 +01:00
9288fccf07
feat(iterators2): adds iterators2 exercise including config
2019-07-03 21:06:24 +10:00
89d5186c0d
fix(test1): renamed function name to snake case
...
closes #180
2019-06-29 01:00:10 +10:00
aaad60d07e
Auto merge of #172 - miller-time:fix-book-links, r=komaeda
...
chore: Fix a couple broken book links
While I was fixing these, I figured maybe it's good to just use a consistent URL for book links: https://doc.rust-lang.org/book/
Is there a plan for what to do with this old 1.4.0 example that doesn't exist in the current version of the book? Perhaps at least include a disclaimer when recommending that folks check it out?
34e31232df/exercises/threads/README.md (L1)
2019-06-23 10:31:50 +00:00
5f16469807
Auto merge of #171 - miller-time:rustfmt-exercises, r=komaeda
...
chore: Clean up some formatting in exercises
I noticed some formatting that isn't consistent with the `rustfmt` style and tried my best to run it on the files in the exercises directory (which does fail for files that can't compile!), which just caught some minor whitespace things here and there.
Note: also can't just apply `rustfmt` blindly because of the blank lines that lead to the hint comments
2019-06-23 10:25:48 +00:00
752bc27e2b
Auto merge of #179 - briankung:fix_irrefutable_let_pattern_structs1, r=komaeda
...
Fixes the irrefutable let pattern warning in `structs1.rs`
PR https://github.com/rust-lang/rustlings/pull/163 accidentally introduced an error using some versions of the Rust compiler where the compiler would (rightly!) complain about an irrefutable let pattern. I have no idea why this did not occur in all versions of the compiler, but here is a way around it.
2019-06-20 15:02:20 +00:00
cc6a14104d
Fixes the irrefutable let pattern warning
2019-06-20 09:46:49 -05:00
eb13c2b6af
chore: Clean up some formatting in exercises
2019-06-11 07:14:43 -07:00
63c133e4a3
chore: Fix a couple broken book links
2019-06-11 07:13:05 -07:00
5586613eec
Auto merge of #170 - miller-time:rename-iterator-exercise, r=komaeda
...
fix(iterators): Rename iterator3.rs
fixes #155
2019-06-11 12:53:58 +00:00
080d6cdd11
chore: Fix link to Arc<T> in the book
2019-06-09 13:45:53 +02:00
433d2115bc
fix(iterators): Rename iterator3.rs
2019-06-07 14:42:44 -07:00
41170ce341
Auto merge of #164 - HanKruiger:master, r=komaeda
...
Fix broken link
2019-05-26 14:07:16 +00:00
fd1441d122
fixed outdated links
2019-05-26 14:57:56 +02:00
e1422c6443
Fix broken link
2019-05-26 14:45:04 +02:00
9b92aa08ae
Adds a simple exercise for structures
2019-05-25 06:39:58 -05:00
8bf8cbbd61
Auto merge of #162 - c-rustacean:rustfmt-and-ws-fixes, r=komaeda
...
errorsn.rs: Separate also the hints from each other to avoid accidental viewing
2019-05-23 11:01:15 +00:00
f507844102
errorsn.rs: Separate also the hints from each other to avoid accidental viewing
...
Signed-off-by: Eddy Petrisor <eddy.petrisor@gmail.com>
2019-05-23 12:21:42 +03:00
fffbb60ed9
Auto merge of #161 - c-rustacean:rustfmt-and-ws-fixes, r=komaeda
...
Rustfmt and ws fixes
2019-05-22 12:29:20 +00:00
9aec4abc4d
rustfmt the exercises
...
Signed-off-by: Eddy Petrisor <eddy.petrisor@gmail.com>
2019-05-22 14:50:40 +03:00
a53b3f199f
iterator3.rs: whitespace fixes
...
Signed-off-by: Eddy Petrisor <eddy.petrisor@gmail.com>
2019-05-22 14:50:40 +03:00
d6d696b66a
errorsn.rs: Separate hints from code, so hints are not accidentally seen
...
Signed-off-by: Eddy Petrisor <eddy.petrisor@gmail.com>
2019-05-22 14:50:39 +03:00
187d2ad226
Update errors1.rs
...
Add Result type signature as it is difficult for new comers to understand Generics and Error all at once
2019-05-12 14:54:37 +02:00
a71bc62c29
Add errors to exercises that compile without user changes
2019-04-22 00:09:30 +02:00
d7e58ee1af
Fix links by deleting book version
2019-04-08 22:02:04 +02:00
c5a374fbf2
Fix permissions on source files
2019-03-23 14:19:42 -06:00
c1f4257a91
errors2.rs: update link to Rust book.
2019-03-16 19:22:06 -07:00
02ceb0ba8c
fix test command execution
...
seems like i forgot that you actually need to run executables created
with `rustc --test`! this also reworks the "test1" exercise a bit
closes #108
2019-02-15 12:06:05 +01:00
4e3bd8d51b
Renamed readme files properly
2019-01-29 21:19:04 +01:00
3073ff3f82
Renamed readme files properly
2019-01-29 21:16:59 +01:00
05f65d67ae
thematically refactor modules2
2019-01-23 21:56:05 +01:00
a49a22071a
redo the section readmes
2019-01-23 21:02:06 +01:00
dc1f3b79f8
add tests; refactor exercise links
2019-01-23 20:48:01 +01:00
17e12433cb
add a test
2019-01-09 21:47:50 +01:00
b90f642029
remove the ex*.rs files
2019-01-09 21:26:12 +01:00
b0c9b33978
Changed Rust Book versions in links to 2018
...
Forgot to add changes to last commit.
2018-11-27 10:54:01 +01:00
zydxhs
ZX
Franklin van Nes
Michael Walsh
xuesong
Fredrik Enestad
Zhenghao Lu
diannasoriel
Taylor Yu
frogtd
Weilet
granddaifuku
anuk909
Damian
ana
Rakshit Sinha
lauralindzey
Laura Lindzey
ZC
Sateesh
Juan Pablo Ramirez
Pi Delport
Martin HART
apogeeoak
Maarten Tibau
Zerotask
Brandon Macer
Shao Yang Hong
k12ish
Pete Pavlovski
Abdou Seck
WowSuchRicky
Ignacio Le Fluk
Rod Elias
Mickael Fortunato
Pascal H
Darius Wiles
cadolphs
Jirka Kremser
Tal
Jean-Francois Chevrette
Sang-Heon Jeon
Christian Zeller
Marius Ungureanu
Axel Viala
seancad
JuliaCao
Peter N
fmoko
Christos Kontas
Jacob Tinkhauser
Wei Hu
JP
fiplox
sazid
Matthew Smillie
Ryan McQuen
Yashodhan Joshi
Greg Leonard
Calvin Brown
Jannek Squar
Koalab99
Samuel Batista
Antoine Barthelemy
John Heath
seeplusplus
Étienne Barrié
Mukund Bhudia
Chad Dougherty
Benjamin Jones
DEWA Kazuyuki/出羽和之
Alexx Roche
Sebastien Caunes
millefalcon
Dan Wilhelm
AlexandruGG
Thomas Sauvajon
Evan Carroll
Jade McGough
Sanjay K
Stefan Kupresak
IkaR49
Gaurang Tandon
Siobhan Jacobson
apatniv
Rob Story
Christofer Bertonha
Jihchi Lee
Dídac Sementé Fernández
Steven Mann
lebedevsergey
Ufuk Celebi
Said Aspen
Tonći Galić
Roberto Vidal
Sanjay K
skim
Mario Reder
bors
Stig Johan Berggren
Jason Tsai
Paul Bissex
Torben Jonas
gnodarse
dmitri-mamrukov
Rahat Ahmed
Jens
Chris Keschnat
Thomas Holloway
Scott Sweeny
Niklas Anderson
Viacheslav Avramenko
Damian S
Dylan Nugent
Enrico Miccoli
Andre Pratama
Pete McFarlane
Jesse
Brian Kung
Russell Cousineau
Rohan Prinja
gushroom
HanKruiger
Eddy Petrisor
Julien Bisconti
Yvan Sraka
Diod FR
zacanger
Kyle Isom
liv
Jean-Philippe Moresmau
delet0r